[
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=426637&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-426637
]
ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/20 17:09
Start Date: 23/Apr/20 17:09
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #11472:
URL: https://github.com/apache/beam/pull/11472#discussion_r413973266
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/ByteBuddyDoFnInvokerFactory.java
##########
@@ -397,12 +396,14 @@ public WatermarkEstimatorStateT getState() {
}
public static class DefaultGetSize {
- /** Uses {@link Sizes.HasSize} to produce the size. */
+ /** Uses {@link HasProgress} to produce the size. */
@SuppressWarnings("unused")
public static <InputT, OutputT> double invokeGetSize(
DoFnInvoker.ArgumentProvider<InputT, OutputT> argumentProvider) {
- if (argumentProvider.restrictionTracker() instanceof HasSize) {
- return ((HasSize) argumentProvider.restrictionTracker()).getSize();
+ if (argumentProvider.restrictionTracker() instanceof HasProgress) {
Review comment:
Yes, because it allows the user to provide an override on how size is
computed without needing to implement a restriction tracker. This is similar to
how a restriction provider can compute the size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 426637)
Time Spent: 31h 20m (was: 31h 10m)
> Fn API SDF support
> ------------------
>
> Key: BEAM-2939
> URL: https://issues.apache.org/jira/browse/BEAM-2939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 31h 20m
> Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
