[
https://issues.apache.org/jira/browse/BEAM-8414?focusedWorklogId=427224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427224
]
ASF GitHub Bot logged work on BEAM-8414:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/20 19:12
Start Date: 25/Apr/20 19:12
Worklog Time Spent: 10m
Work Description: stephenoken commented on a change in pull request
#11523:
URL: https://github.com/apache/beam/pull/11523#discussion_r415124678
##########
File path: sdks/python/apache_beam/io/restriction_trackers.py
##########
@@ -137,7 +137,7 @@ def try_claim(self, position):
'of the range. Tried to claim position %r for the range [%r, %r)' %
(position, self._range.start, self._range.stop))
- if position >= self._range.start and position < self._range.stop:
+ if self._range.start >= position < self._range.stop:
Review comment:
oh my bad. thanks for catching that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 427224)
Time Spent: 1h 40m (was: 1.5h)
> Cleanup Python codebase to enable some of the excluded Python lint checks.
> ---------------------------------------------------------------------------
>
> Key: BEAM-8414
> URL: https://issues.apache.org/jira/browse/BEAM-8414
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Stephen O'Kennedy
> Priority: Minor
> Labels: beginner, easy, easy-fix, easyfix, newbie, starter
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/pull/9725 upgraded lint checker, however Beam
> codebase is not fully compliant with some of the checks new linter supports,
> so we excluded such checks. We would like to have some checks permanently
> excluded (see discussion on the PR), however we would like to re-enable the
> following checks:
> consider-using-set-comprehension
> chained-comparison
> consider-using-sys-exit
> To reenable these checks, we should:
> 1) remove them from disabled checks in .pylintrc [1]
> https://github.com/apache/beam/blob/master/sdks/python/.pylintrc and
> 2) cleanup the codebase to make it compliant.
> [1]
> https://github.com/apache/beam/blob/3330069291d8168c56c77acfef84c2566af05ec6/sdks/python/.pylintrc#L81
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
