[
https://issues.apache.org/jira/browse/BEAM-9797?focusedWorklogId=429146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429146
]
ASF GitHub Bot logged work on BEAM-9797:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/20 17:13
Start Date: 30/Apr/20 17:13
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#11502:
URL: https://github.com/apache/beam/pull/11502#discussion_r418163527
##########
File path: sdks/java/container/license_scripts/pull_licenses_java.py
##########
@@ -35,18 +35,9 @@
from tenacity import retry
from tenacity import stop_after_attempt
from tenacity import wait_exponential
+from urllib.request import urlopen, URLError, HTTPError
+
-try:
- # py2
- from future.moves.urllib.request import urlopen
- from future.moves.urllib.request import URLError, HTTPError
-except:
- # py3
- from future import standard_library
- from urllib.request import urlopen, URLError, HTTPError
Review comment:
> Can you please check what version of Python was installed at
sdks/java/container/build/virtualenv?
```
❯ ./sdks/java/container/build/virtualenv/bin/python --version
Python 2.7.18rc1
```
If this is working for others maybe I just have something else wrong with my
setup...
> Does adding --python=python3 to the virtualenv command fix this for you,
Brian?
yeah that's what I did to get it passing. I thought about putting up a PR
for the change, but not sure if that's a universal solution or not.
##########
File path: sdks/java/container/license_scripts/pull_licenses_java.py
##########
@@ -35,18 +35,9 @@
from tenacity import retry
from tenacity import stop_after_attempt
from tenacity import wait_exponential
+from urllib.request import urlopen, URLError, HTTPError
+
-try:
- # py2
- from future.moves.urllib.request import urlopen
- from future.moves.urllib.request import URLError, HTTPError
-except:
- # py3
- from future import standard_library
- from urllib.request import urlopen, URLError, HTTPError
Review comment:
> Can you please check what version of Python was installed at
sdks/java/container/build/virtualenv?
```
❯ ./sdks/java/container/build/virtualenv/bin/python --version
Python 2.7.18rc1
```
If this is working for others maybe I just have something else wrong with my
setup...
> Does adding --python=python3 to the virtualenv command fix this for you,
Brian?
yeah that's what I did to get it passing. I thought about putting up a PR
for the change, but not sure if that's a universal solution or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 429146)
Time Spent: 4h 20m (was: 4h 10m)
> license_script.sh calls pip install/uninstall in local env
> ----------------------------------------------------------
>
> Key: BEAM-9797
> URL: https://issues.apache.org/jira/browse/BEAM-9797
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Udi Meiri
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> File is:
> https://github.com/apache/beam/blob/master/sdks/java/container/license_scripts/license_script.sh
> The problem is with the code that does pip install and uninstall.
> 1. It is not okay to modify the local environment.
> 2. Running this script in parallel with itself (on Jenkins) has a chance to
> cause a race.
> The solution is to use a tox environment to run this script in. Tox will take
> care of creating a virtualenv with the required dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
