[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=429256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429256
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/20 20:49
Start Date: 30/Apr/20 20:49
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on a change in pull request
#11584:
URL: https://github.com/apache/beam/pull/11584#discussion_r418278914
##########
File path: sdks/python/container/py2/build.gradle
##########
@@ -66,7 +66,8 @@ docker {
project.rootProject["docker-tag"] : project.sdk_version)
files "../Dockerfile", "./build"
buildArgs(['py_version': "2.7",
- 'pull_licenses':
project.rootProject.hasProperty(["docker-pull-licenses"])])
+ 'pull_licenses':
project.rootProject.hasProperty(["docker-pull-licenses"]) ||
+ project.rootProject.hasProperty(["isRelease"])])
Review comment:
Currently, the `isRelease` tag needs to be passed with commands.
Ideally, this tag should be set by checking branch name.
Detecting `isRelease` for docker image build is not that helpful for now,
but could be used when we support auto setting `isRelease` tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 429256)
Time Spent: 28.5h (was: 28h 20m)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 28.5h
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
