[
https://issues.apache.org/jira/browse/BEAM-7554?focusedWorklogId=429557&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429557
]
ASF GitHub Bot logged work on BEAM-7554:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/20 16:49
Start Date: 01/May/20 16:49
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#11456:
URL: https://github.com/apache/beam/pull/11456#discussion_r418628471
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamAggregationRel.java
##########
@@ -257,10 +257,8 @@ private Transform(
// Combining over a single field, so extract just that field.
combined =
(combined == null)
- ? byFields.aggregateFieldBaseValue(
- inputs.get(0), combineFn, fieldAggregation.outputField)
- : combined.aggregateFieldBaseValue(
- inputs.get(0), combineFn, fieldAggregation.outputField);
+ ? byFields.aggregateField(inputs.get(0), combineFn,
fieldAggregation.outputField)
+ : combined.aggregateField(inputs.get(0), combineFn,
fieldAggregation.outputField);
Review comment:
What about adding the option for SqlTransform to convert unknown logical
types to their base type at the input? I think that behavior would be
effectively the same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 429557)
Time Spent: 50m (was: 40m)
> datetime and decimal should be logical types
> --------------------------------------------
>
> Key: BEAM-7554
> URL: https://issues.apache.org/jira/browse/BEAM-7554
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql, sdk-java-core
> Reporter: Brian Hulette
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently datetime and decimal are implemented as primitive types in the Java
> SDK. They should be logical types as documented in
> https://s.apache.org/beam-schemas
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
