[
https://issues.apache.org/jira/browse/BEAM-9870?focusedWorklogId=430276&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430276
]
ASF GitHub Bot logged work on BEAM-9870:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/20 16:25
Start Date: 04/May/20 16:25
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #11593:
URL: https://github.com/apache/beam/pull/11593#discussion_r419562334
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -345,7 +345,7 @@ def visit_transform(self, transform_node):
for ix, side_input in enumerate(transform_node.side_inputs):
access_pattern = side_input._side_input_data().access_pattern
if access_pattern == common_urns.side_inputs.ITERABLE.urn:
- if use_unified_worker:
+ if use_unified_worker or not use_fn_api:
Review comment:
Yes, in non-FnAPI mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 430276)
Time Spent: 1h 10m (was: 1h)
> Beam protos created without fn_api set incompatible with Dataflow on FnAPI.
> ---------------------------------------------------------------------------
>
> Key: BEAM-9870
> URL: https://issues.apache.org/jira/browse/BEAM-9870
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Blocker
> Fix For: 2.21.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This will make auto-opt-in impossible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
