[
https://issues.apache.org/jira/browse/BEAM-9383?focusedWorklogId=430497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430497
]
ASF GitHub Bot logged work on BEAM-9383:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/20 02:57
Start Date: 05/May/20 02:57
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r419838456
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##########
@@ -336,25 +323,26 @@ public DataflowPackage stageToFile(
final AtomicInteger numCached = new AtomicInteger(0);
List<CompletionStage<DataflowPackage>> destinationPackages = new
ArrayList<>();
- for (String classpathElement : classpathElements) {
- DataflowPackage sourcePackage = new DataflowPackage();
- if (classpathElement.contains("=")) {
- String[] components = classpathElement.split("=", 2);
- sourcePackage.setName(components[0]);
- sourcePackage.setLocation(components[1]);
- } else {
- sourcePackage.setName(null);
- sourcePackage.setLocation(classpathElement);
+ for (StagedFile classpathElement : classpathElements) {
+ DataflowPackage targetPackage = classpathElement.getStagedPackage();
+ String source = classpathElement.getSource();
+ if (source.contains("=")) {
Review comment:
removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 430497)
Time Spent: 7h 40m (was: 7.5h)
> Staging Dataflow artifacts from environment
> -------------------------------------------
>
> Key: BEAM-9383
> URL: https://issues.apache.org/jira/browse/BEAM-9383
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> Staging Dataflow artifacts from environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
