[
https://issues.apache.org/jira/browse/BEAM-9836?focusedWorklogId=430585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430585
]
ASF GitHub Bot logged work on BEAM-9836:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/20 09:03
Start Date: 05/May/20 09:03
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #11559:
URL: https://github.com/apache/beam/pull/11559#issuecomment-623940748
I see, thanks for the info @rehmanmuradali and @reuvenlax.
It seems this is only for `ParDo`, my point here is not to be annoying it is
that I can imagine in the future someone annotating their tests with `UsesKey`
just because the tests use a Key (like in KV) and I want to prevent this. What
about naming it `UsesKeyInParDo` ?
Also it seems then that the current documentation for the class is not ok
too, can you please also mention of the `OnWindowExpiration` and
`ProcessElement` case.
```java
/**
* Category tag for validation tests which use key. Tests tagged with {@link
UsesKey} should be run
* for runners which support key parameter in {@link OnTimer}.
*/
```
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 430585)
Time Spent: 2h 10m (was: 2h)
> ParDoTest$KeyTests.testKeyInOnTimer(WithGenericKey) failing on Classic Spark
> ValidatesRunner tests
> --------------------------------------------------------------------------------------------------
>
> Key: BEAM-9836
> URL: https://issues.apache.org/jira/browse/BEAM-9836
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Kyle Weaver
> Assignee: Rehman Murad Ali
> Priority: Major
> Fix For: 2.22.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> beam_PostCommit_Java_ValidatesRunner_Spark is red.
> testKeyInOnTimer fails with:
> org.apache.beam.sdk.Pipeline$PipelineExecutionException:
> java.lang.NumberFormatException: null
> testKeyInOnTimerWithGenericKey fails with:
> org.apache.beam.sdk.Pipeline$PipelineExecutionException:
> java.lang.NullPointerException
> This can be reproduced locally by running `/gradlew
> :runners:spark:validatesRunnerBatch --tests "*ParDoTest\$KeyTests*" --scan`
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
