[ https://issues.apache.org/jira/browse/BEAM-9888?focusedWorklogId=430772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430772 ]
ASF GitHub Bot logged work on BEAM-9888: ---------------------------------------- Author: ASF GitHub Bot Created on: 05/May/20 16:36 Start Date: 05/May/20 16:36 Worklog Time Spent: 10m Work Description: je-ik commented on pull request #11612: URL: https://github.com/apache/beam/pull/11612#issuecomment-624163277 cc @dmvk @JozoVilcek ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 430772) Time Spent: 40m (was: 0.5h) > @RequiresTimeSortedInput might feed data out of order > ----------------------------------------------------- > > Key: BEAM-9888 > URL: https://issues.apache.org/jira/browse/BEAM-9888 > Project: Beam > Issue Type: Bug > Components: runner-core > Affects Versions: 2.20.0 > Reporter: Jan Lukavský > Assignee: Jan Lukavský > Priority: Major > Fix For: 2.21.0 > > Time Spent: 40m > Remaining Estimate: 0h > > StatefulDoFnRunner drops late data based on output watermark, but output > watermark might not advance fast enough to discard data that should have been > dropped. We have to either: > a) drop data based on input watermark, or > b) drop data based on timestamp of last emitted element > I'm a little in favor of b), because it can drop less data. -- This message was sent by Atlassian Jira (v8.3.4#803005)