[
https://issues.apache.org/jira/browse/BEAM-9825?focusedWorklogId=431426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431426
]
ASF GitHub Bot logged work on BEAM-9825:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/20 21:02
Start Date: 06/May/20 21:02
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #11610:
URL: https://github.com/apache/beam/pull/11610#issuecomment-624889206
> > Thanks!
> > In terms of naming, I found it surprising that union (for example) does
deduplication. Maybe name them distinctUnion and multisetUnion or something
like that?
>
> > Thanks!
> > In terms of naming, I found it surprising that union (for example) does
deduplication. Maybe name them distinctUnion and multisetUnion or something
like that?
>
> I don't have strong view here but I feel that as it is inside `SetFns` and
will be used like `SetFns.union`, it follows SET DISTINCT semantics. It is
equivalent of UNION in SQL like `A U B`.Also all other functions in `SetFns`
follow SET DISTINCT semantics. What is your view, how do we make it better?
I am wondering if you can use a bool flag to indicate it is "ALL" or
"DISTINCT" semantics. By doing so there is no naming problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 431426)
Remaining Estimate: 92h 10m (was: 92h 20m)
Time Spent: 3h 50m (was: 3h 40m)
> Transforms for Intersect, IntersectAll, Except, ExceptAll, Union, UnionAll
> --------------------------------------------------------------------------
>
> Key: BEAM-9825
> URL: https://issues.apache.org/jira/browse/BEAM-9825
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Darshan Jani
> Assignee: Darshan Jani
> Priority: Major
> Original Estimate: 96h
> Time Spent: 3h 50m
> Remaining Estimate: 92h 10m
>
> I'd like to propose following new high-level transforms.
> * Intersect
> Compute the intersection between elements of two PCollection.
> Given _leftCollection_ and _rightCollection_, this transform returns a
> collection containing elements that common to both _leftCollection_ and
> _rightCollection_
>
> * Except
> Compute the difference between elements of two PCollection.
> Given _leftCollection_ and _rightCollection_, this transform returns a
> collection containing elements that are in _leftCollection_ but not in
> _rightCollection_
> * Union
> Find the elements that are either of two PCollection.
> Implement IntersetAll, ExceptAll and UnionAll variants of transforms.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
