[
https://issues.apache.org/jira/browse/BEAM-8949?focusedWorklogId=432143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432143
]
ASF GitHub Bot logged work on BEAM-8949:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/20 14:41
Start Date: 08/May/20 14:41
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#11210:
URL: https://github.com/apache/beam/pull/11210#discussion_r422182633
##########
File path: sdks/python/apache_beam/io/gcp/experimental/spannerio.py
##########
@@ -1008,31 +1007,30 @@ def _reset_count(self):
self._cells = 0
def process(self, element):
- mg_info = element.info
+ for elem in element:
+ mg_info = elem.info
+ if mg_info['byte_size'] + self._size_in_bytes > \
Review comment:
I think (2) is better but we should fix the Spanner connector
implementation to work for arbitrary bundle sizes than reducing the bundle to a
single element for the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 432143)
Time Spent: 10h 20m (was: 10h 10m)
> Add Spanner IO Integration Test for Python
> ------------------------------------------
>
> Key: BEAM-8949
> URL: https://issues.apache.org/jira/browse/BEAM-8949
> Project: Beam
> Issue Type: Test
> Components: io-py-gcp
> Reporter: Shoaib Zafar
> Assignee: Shoaib Zafar
> Priority: Major
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Spanner IO (Python SDK) contains PTransform which uses the BatchAPI to read
> from the spanner. Currently, it only contains direct runner unit tests. In
> order to make this functionality available for the users, integration tests
> also need to be added.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
