[
https://issues.apache.org/jira/browse/BEAM-9876?focusedWorklogId=432221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432221
]
ASF GitHub Bot logged work on BEAM-9876:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/20 19:15
Start Date: 08/May/20 19:15
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#11554:
URL: https://github.com/apache/beam/pull/11554#discussion_r422323757
##########
File path: website/Dockerfile
##########
@@ -1,33 +1,65 @@
-###############################################################################
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# http://www.apache.org/licenses/LICENSE-2.0
#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-###############################################################################
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
-# This image contains Ruby and dependencies required to build and test the Beam
-# website. It is used by tasks in build.gradle.
Review comment:
nit: could you add a comment like this at the start of the new
Dockerfile?
Also some comments above each of the "RUN" statements below saying what
they're doing would be nice. They're a little inscrutable by themselves, but
some comments like "Install misc deps", "Install node", "Install yarn" would
make it easy to inspect
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 432221)
Time Spent: 9h 10m (was: 9h)
> Migrate the Beam website from Jekyll to Hugo to enable localization of the
> site content
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-9876
> URL: https://issues.apache.org/jira/browse/BEAM-9876
> Project: Beam
> Issue Type: Task
> Components: website
> Reporter: Aizhamal Nurmamat kyzy
> Assignee: Aizhamal Nurmamat kyzy
> Priority: Major
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
> Enable internationalization of the Apache Beam website to increase the reach
> of the project, and facilitate adoption and growth of its community.
> The proposal was to do this by migrating the current Apache Beam website from
> Jekyll do Hugo [1]. Hugo supports internationalization out-of-the-box, making
> it easier both for contributors and maintainers support the
> internationalization effort.
> The further discussion on implementation can be viewed here [2]
> [1]
> [https://lists.apache.org/thread.html/rfab4cc1411318c3f4667bee051df68f37be11846ada877f3576c41a9%40%3Cdev.beam.apache.org%3E]
> [2]
> [https://lists.apache.org/thread.html/r6b999b6d7d1f6cbb94e16bb2deed2b65098a6b14c4ac98707fe0c36a%40%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
