[ 
https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=432738&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432738
 ]

ASF GitHub Bot logged work on BEAM-9742:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/May/20 11:42
            Start Date: 11/May/20 11:42
    Worklog Time Spent: 10m 
      Work Description: aromanenko-dev commented on a change in pull request 
#11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r422977908



##########
File path: 
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -257,6 +258,28 @@ public boolean apply(SQLException e) {
     }
   }
 
+  /**
+   * This is the default {@link FluentBackoffConfiguration} that we use to 
retry when a {@link
+   * SQLException} occurs.
+   */
+  public static class DefaultFluentBackoffConfiguration implements 
FluentBackoffConfiguration {

Review comment:
       I agree with @lukecwik - we should stay consistent with that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 432738)
    Time Spent: 2h 10m  (was: 2h)

> Add ability to pass FluentBackoff to JdbcIo.Write
> -------------------------------------------------
>
>                 Key: BEAM-9742
>                 URL: https://issues.apache.org/jira/browse/BEAM-9742
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-jdbc
>            Reporter: Akshay Iyangar
>            Assignee: Akshay Iyangar
>            Priority: Minor
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Currently, the FluentBackoff is hardcoded with `maxRetries` and 
> `initialBackoff` .
> It would be helpful if the client were able to pass these values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to