[
https://issues.apache.org/jira/browse/BEAM-8132?focusedWorklogId=432778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432778
]
ASF GitHub Bot logged work on BEAM-8132:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/20 12:48
Start Date: 11/May/20 12:48
Worklog Time Spent: 10m
Work Description: kkucharc commented on a change in pull request #11567:
URL: https://github.com/apache/beam/pull/11567#discussion_r423014250
##########
File path: sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -404,6 +419,77 @@ def save(self, results):
return self._client.insert_rows(self._bq_table, results)
+class InfluxDBMetricsPublisherOptions(object):
+ def __init__(
+ self,
+ measurement, # type: str
+ db_name, # type: str
+ hostname='http://localhost:8086', # type: str
Review comment:
Then maybe we should have param without default value? I can imagine
case when someone doesn't know why metrics tries to be saved to this host
without checking this code deeper?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 432778)
Time Spent: 6h 10m (was: 6h)
> Create metrics publisher in Python SDK
> --------------------------------------
>
> Key: BEAM-8132
> URL: https://issues.apache.org/jira/browse/BEAM-8132
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kamil Wasilewski
> Assignee: Kamil Wasilewski
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
