[ 
https://issues.apache.org/jira/browse/BEAM-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105627#comment-17105627
 ] 

Luke Cwik commented on BEAM-6327:
---------------------------------

I think this shouldn't be considered "trimming" but native transform 
replacement and have crafted https://github.com/apache/beam/pull/11670 which 
repurposes this as such. The version that was in the trimmer was a trivial 
implementation that covers many scenarios where the runner doesn't need custom 
replacement/expansion logic.

> Don't attempt to fuse subtransforms of primitive/known transforms.
> ------------------------------------------------------------------
>
>                 Key: BEAM-6327
>                 URL: https://issues.apache.org/jira/browse/BEAM-6327
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-direct
>            Reporter: Robert Bradshaw
>            Assignee: Kyle Weaver
>            Priority: Major
>              Labels: portability
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Currently we must remove all sub-components of any known transform that may 
> have an optional substructure, e.g. 
> [https://github.com/apache/beam/blob/release-2.9.0/sdks/python/apache_beam/runners/portability/portable_runner.py#L126]
>  (for GBK) and [https://github.com/apache/beam/pull/7360] (Reshuffle).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to