[
https://issues.apache.org/jira/browse/BEAM-9928?focusedWorklogId=432789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432789
]
ASF GitHub Bot logged work on BEAM-9928:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/20 19:31
Start Date: 13/May/20 19:31
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #11690:
URL: https://github.com/apache/beam/pull/11690#discussion_r424681041
##########
File path: learning/katas/go/Core Transforms/Map/ParDo Struct/task.md
##########
@@ -18,16 +18,16 @@
-->
# ParDo - using a struct as a DoFn
-In previous katas, we provided our ParDo a `func` as a DoFn. In this example,
we will explore
-the use of a `struct` to in our transform.
+In previous katas, we provided `beam.ParDo` a `func` as a DoFn. In this
example, we will explore
Review comment:
I guess I could go either way?
Including the identifier "beam." is more specific and I like it better
visually. (especially with the `codefont` indication).
Reading it aloud it is certainly more of a mouthful than without "beam.",
but that's should only be a problem for very novice readers who aren't
subtising the words they read yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 432789)
Time Spent: 0.5h (was: 20m)
> Edit task descriptors with qualified import name | Go SDK Code Katas
> --------------------------------------------------------------------
>
> Key: BEAM-9928
> URL: https://issues.apache.org/jira/browse/BEAM-9928
> Project: Beam
> Issue Type: Sub-task
> Components: katas, sdk-go
> Reporter: Damon Douglas
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> See original PR comment:
> https://github.com/apache/beam/pull/11564#discussion_r419628874
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
