[
https://issues.apache.org/jira/browse/BEAM-9692?focusedWorklogId=432853&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432853
]
ASF GitHub Bot logged work on BEAM-9692:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/20 21:53
Start Date: 13/May/20 21:53
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on a change in pull request
#11503:
URL: https://github.com/apache/beam/pull/11503#discussion_r424753027
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner_test.py
##########
@@ -404,10 +396,6 @@ def test_gbk_then_flatten_input_visitor(self):
flat = (none_str_pc, none_int_pc) | beam.Flatten()
_ = flat | beam.GroupByKey()
- # This may change if type inference changes, but we assert it here
- # to make sure the check below is not vacuous.
Review comment:
I added it back in. The DataflowRunner should change the element type
and we should test before and after.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 432853)
Time Spent: 3h 40m (was: 3.5h)
> Clean Python DataflowRunner to use portable pipelines
> -----------------------------------------------------
>
> Key: BEAM-9692
> URL: https://issues.apache.org/jira/browse/BEAM-9692
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
