[
https://issues.apache.org/jira/browse/BEAM-9430?focusedWorklogId=432956&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432956
]
ASF GitHub Bot logged work on BEAM-9430:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/20 02:13
Start Date: 14/May/20 02:13
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #11607:
URL: https://github.com/apache/beam/pull/11607#discussion_r424831998
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/WatermarkEstimator.java
##########
@@ -44,4 +45,19 @@
* <p>The state returned must not be mutated.
*/
WatermarkEstimatorStateT getState();
+
+ /**
+ * Validates that a given watermark is within timestamp min and max bounds.
+ *
+ * @param watermark watermark to validate
+ */
+ static void ensureWatermarkWithinBounds(Instant watermark) {
Review comment:
It makes more sense to add this method to BoundedWindow as it should
apply to a lot more places then just WatermarkEstimators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 432956)
Time Spent: 8h (was: 7h 50m)
> Migrate from ProcessContext#updateWatermark to WatermarkEstimators
> ------------------------------------------------------------------
>
> Key: BEAM-9430
> URL: https://issues.apache.org/jira/browse/BEAM-9430
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Labels: backward-incompatible
> Fix For: 2.21.0
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> Current discussion underway in
> [https://lists.apache.org/thread.html/r5d974b6a58bc04ff4c02682fda4ef68608121f1bf23a86e9d592ca6e%40%3Cdev.beam.apache.org%3E]
>
> Proposed API: [https://github.com/apache/beam/pull/10992]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
