[
https://issues.apache.org/jira/browse/BEAM-9729?focusedWorklogId=433880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-433880
]
ASF GitHub Bot logged work on BEAM-9729:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/20 20:02
Start Date: 15/May/20 20:02
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #11720:
URL: https://github.com/apache/beam/pull/11720#discussion_r426020019
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##########
@@ -206,18 +205,16 @@ public static void main(
LoadingCache<String, BeamFnApi.ProcessBundleDescriptor>
processBundleDescriptors =
CacheBuilder.newBuilder()
+ .maximumSize(1000)
+ .expireAfterAccess(10, TimeUnit.MINUTES)
Review comment:
This is the time duration between never seeing a bundle of this type and
discarding its description from the cache. It could be smaller, but I figured
it was good to start out very conservatively (both count and time).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 433880)
Time Spent: 3.5h (was: 3h 20m)
> Cleanup bundle registration now that SDKs can pull.
> ---------------------------------------------------
>
> Key: BEAM-9729
> URL: https://issues.apache.org/jira/browse/BEAM-9729
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Once all runners (in particular dataflow) support pull descriptors, we can
> clean things up by removing the push registration code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
