[
https://issues.apache.org/jira/browse/BEAM-10018?focusedWorklogId=434165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-434165
]
ASF GitHub Bot logged work on BEAM-10018:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/20 10:04
Start Date: 17/May/20 10:04
Worklog Time Spent: 10m
Work Description: iht commented on a change in pull request #11731:
URL: https://github.com/apache/beam/pull/11731#discussion_r426241932
##########
File path: learning/katas/python/Windowing/Fixed Time Window/Fixed Time
Window/task-info.yaml
##########
@@ -22,7 +22,7 @@ files:
- name: task.py
visible: true
placeholders:
- - offset: 2074
+ - offset: 2067
Review comment:
I am checking the boundaries of the placeholder in PyCharm, and I see it
correctly
Maybe you were checking the previous placeholder box? I see that the box is
starting 7 positions to the right (2074, after the `Wi`), and the placeholder I
am submitting is starting 7 positions to the left (2067).
I have removed all the Placeholders and created them again by selecting the
answer in the code, and using right click "Add answer placeholder", and the
bounding boxes are the same I have committed (same values in the section
`placeholders` in `task-info.yaml`). I am not sure if I am doing something
wrong though. It is the first time I generate Edu content for PyCharm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 434165)
Time Spent: 1h 10m (was: 1h)
> Windowing katas are failing because timestamps are being calculated in local
> timezones
> --------------------------------------------------------------------------------------
>
> Key: BEAM-10018
> URL: https://issues.apache.org/jira/browse/BEAM-10018
> Project: Beam
> Issue Type: Bug
> Components: katas
> Affects Versions: 2.20.0
> Reporter: Israel Herraiz
> Assignee: Israel Herraiz
> Priority: P2
> Fix For: 2.21.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The two Python katas about windowing fail because the timestamps for the
> elements are calculated based on the local timezone, and my timezone does not
> match the timezone hardcoded in the tests.
> I am working on a pull request to set the timezones in UTC, so the tests are
> always done in UTC, and the timestamps are always set in UTC.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
