[
https://issues.apache.org/jira/browse/BEAM-9363?focusedWorklogId=434708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-434708
]
ASF GitHub Bot logged work on BEAM-9363:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/20 00:50
Start Date: 19/May/20 00:50
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #10946:
URL: https://github.com/apache/beam/pull/10946#discussion_r426968398
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##########
@@ -175,6 +185,37 @@ private void addBuiltinFunctionsToCatalog(SimpleCatalog
catalog, AnalyzerOptions
Mode.SCALAR,
ImmutableList.of(resolvedFunc.getSignature())))
.forEach(catalog::addFunction);
+
+ FunctionArgumentType retType =
+ new FunctionArgumentType(SignatureArgumentKind.ARG_TYPE_RELATION);
+
+ FunctionArgumentType inputTableType =
+ new FunctionArgumentType(SignatureArgumentKind.ARG_TYPE_RELATION);
+
+ FunctionArgumentType descriptorType =
+ new FunctionArgumentType(
+ SignatureArgumentKind.ARG_TYPE_DESCRIPTOR,
+ FunctionArgumentTypeOptionsProto.newBuilder()
+ .setDescriptorResolutionTableOffset(0)
+ .build(),
+ 1);
+
+ FunctionArgumentType stringType =
+ new
FunctionArgumentType(TypeFactory.createSimpleType(TypeKind.TYPE_STRING));
+
+ // TUMBLE
+ catalog.addTableValuedFunction(
+ new
TableValuedFunction.ForwardInputSchemaToOutputSchemaWithAppendedColumnTVF(
Review comment:
Yeah. And at least I am glad this name itself does not exceed 80 chars
so it at least fits into a single line..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 434708)
Time Spent: 5h 40m (was: 5.5h)
> BeamSQL windowing as TVF
> ------------------------
>
> Key: BEAM-9363
> URL: https://issues.apache.org/jira/browse/BEAM-9363
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql, dsl-sql-zetasql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: P2
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> This Jira tracks the implementation for
> https://s.apache.org/streaming-beam-sql
> TVF is table-valued function, which is a SQL feature that produce a table as
> function's output.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
