[
https://issues.apache.org/jira/browse/BEAM-9383?focusedWorklogId=434721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-434721
]
ASF GitHub Bot logged work on BEAM-9383:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/20 01:10
Start Date: 19/May/20 01:10
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426973945
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -784,7 +877,25 @@ public DataflowPipelineJob run(Pipeline pipeline) {
"Executing pipeline on the Dataflow Service, which will have billing
implications "
+ "related to Google Compute Engine usage and other Google Cloud
Services.");
- List<DataflowPackage> packages = options.getStager().stageDefaultFiles();
+ // Capture the sdkComponents for look up during step translations
+ SdkComponents sdkComponents = SdkComponents.create();
+
+ DataflowPipelineOptions dataflowOptions =
options.as(DataflowPipelineOptions.class);
+ String workerHarnessContainerImageURL =
DataflowRunner.getContainerImageForJob(dataflowOptions);
+ RunnerApi.Environment defaultEnvironmentForDataflow =
+ Environments.createDockerEnvironment(workerHarnessContainerImageURL);
+
+ sdkComponents.registerEnvironment(
+ defaultEnvironmentForDataflow
+ .toBuilder()
+ .addAllDependencies(getDefaultArtifacts())
Review comment:
We also need to make sure we have the capabilities set, I have this PR:
https://github.com/apache/beam/pull/11748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 434721)
Time Spent: 10h 20m (was: 10h 10m)
> Staging Dataflow artifacts from environment
> -------------------------------------------
>
> Key: BEAM-9383
> URL: https://issues.apache.org/jira/browse/BEAM-9383
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P0
> Fix For: 2.22.0
>
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Staging Dataflow artifacts from environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
