[
https://issues.apache.org/jira/browse/BEAM-9339?focusedWorklogId=434724&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-434724
]
ASF GitHub Bot logged work on BEAM-9339:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/20 01:12
Start Date: 19/May/20 01:12
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #11748:
URL: https://github.com/apache/beam/pull/11748#discussion_r426974286
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##########
@@ -183,7 +183,10 @@ public JobSpecification translate(
String workerHarnessContainerImageURL =
DataflowRunner.getContainerImageForJob(options.as(DataflowPipelineOptions.class));
RunnerApi.Environment defaultEnvironmentForDataflow =
- Environments.createDockerEnvironment(workerHarnessContainerImageURL);
+ Environments.createDockerEnvironment(workerHarnessContainerImageURL)
+ .toBuilder()
+ .addAllCapabilities(Environments.getJavaCapabilities())
Review comment:
Is there some common utility we should be using here (rather than
duplicating the code that's used in all the other portable runners)? What about
requirements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 434724)
Time Spent: 8h (was: 7h 50m)
> Declare capabilities in SDK environments
> ----------------------------------------
>
> Key: BEAM-9339
> URL: https://issues.apache.org/jira/browse/BEAM-9339
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go, sdk-java-harness, sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: P2
> Fix For: 2.22.0
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
