[
https://issues.apache.org/jira/browse/BEAM-8889?focusedWorklogId=435175&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-435175
]
ASF GitHub Bot logged work on BEAM-8889:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/20 20:30
Start Date: 19/May/20 20:30
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#11651:
URL: https://github.com/apache/beam/pull/11651#discussion_r427580442
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -489,6 +490,7 @@ class BeamModulePlugin implements Plugin<Project> {
grpc_protobuf :
"io.grpc:grpc-protobuf:$grpc_version",
grpc_protobuf_lite :
"io.grpc:grpc-protobuf-lite:$grpc_version",
grpc_netty :
"io.grpc:grpc-netty:$grpc_version",
+ grpc_netty_shaded :
"io.grpc:grpc-netty-shaded:$grpc_version",
Review comment:
Why do we need both grpc_netty and grpc_netty_shaded ?
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -56,11 +56,13 @@ dependencies {
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
compile library.java.grpc_all
+ compile library.java.grpc_alts
compile library.java.grpc_auth
compile library.java.grpc_core
compile library.java.grpc_context
compile library.java.grpc_grpclb
compile library.java.grpc_netty
+ compile library.java.grpc_netty_shaded
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 435175)
Remaining Estimate: 135h 40m (was: 135h 50m)
Time Spent: 32h 20m (was: 32h 10m)
> Make GcsUtil use GoogleCloudStorage
> -----------------------------------
>
> Key: BEAM-8889
> URL: https://issues.apache.org/jira/browse/BEAM-8889
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.16.0
> Reporter: Esun Kim
> Assignee: VASU NORI
> Priority: P2
> Labels: gcs
> Original Estimate: 168h
> Time Spent: 32h 20m
> Remaining Estimate: 135h 40m
>
> [GcsUtil|https://github.com/apache/beam/blob/master/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java]
> is a primary class to access Google Cloud Storage on Apache Beam. Current
> implementation directly creates GoogleCloudStorageReadChannel and
> GoogleCloudStorageWriteChannel by itself to read and write GCS data rather
> than using
> [GoogleCloudStorage|https://github.com/GoogleCloudPlatform/bigdata-interop/blob/master/gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorage.java]
> which is an abstract class providing basic IO capability which eventually
> creates channel objects. This request is about updating GcsUtil to use
> GoogleCloudStorage to create read and write channel, which is expected
> flexible because it can easily pick up the new change; e.g. new channel
> implementation using new protocol without code change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
