[
https://issues.apache.org/jira/browse/BEAM-10007?focusedWorklogId=435250&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-435250
]
ASF GitHub Bot logged work on BEAM-10007:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/20 22:54
Start Date: 19/May/20 22:54
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #11744:
URL: https://github.com/apache/beam/pull/11744#discussion_r427645484
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -164,10 +165,19 @@ def add_runner_options(parser):
all_options = self.options.get_all_options(
add_extra_args_fn=add_runner_options,
retain_unknown_options=self._retain_unknown_options)
+
# TODO: Define URNs for options.
# convert int values: https://issues.apache.org/jira/browse/BEAM-5509
+ def convert_pipeline_option_value(v):
+ if type(v) == int:
Review comment:
Interesting. For this PR, could you move that comment closer to the if
type(v) == int line.
> I can look into fixing that upstream so we can get rid of the special case
here.
If you have time, maybe file a bug. I do not think this is a very high
priority for us.
> I don't think it would be good to call str(v) on everything
I agree. I was trying to understand why are we doing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 435250)
Time Spent: 50m (was: 40m)
> PortableRunner doesn't handle ValueProvider instances when converting
> pipeline options
> --------------------------------------------------------------------------------------
>
> Key: BEAM-10007
> URL: https://issues.apache.org/jira/browse/BEAM-10007
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Brian Hulette
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We attempt to convert ValueProvider instances directly to JSON with
> json_format, leading to errors like the one described in BEAM-9975.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
