[
https://issues.apache.org/jira/browse/BEAM-9899?focusedWorklogId=435257&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-435257
]
ASF GitHub Bot logged work on BEAM-9899:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/20 23:02
Start Date: 19/May/20 23:02
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #11701:
URL: https://github.com/apache/beam/pull/11701#discussion_r427648180
##########
File path: sdks/python/apache_beam/coders/row_coder.py
##########
@@ -134,19 +134,18 @@ def __init__(self, schema, components):
def encode_to_stream(self, value, out, nested):
nvals = len(self.schema.fields)
self.SIZE_CODER.encode_to_stream(nvals, out, True)
- attrs = [getattr(value, f.name) for f in self.schema.fields]
Review comment:
This forces the value to be an iterable, rather than just having the
right fields, right? Are we sure we want to do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 435257)
Time Spent: 0.5h (was: 20m)
> Add integration tests for cross-language SnowflakeIO Read and Write
> -------------------------------------------------------------------
>
> Key: BEAM-9899
> URL: https://issues.apache.org/jira/browse/BEAM-9899
> Project: Beam
> Issue Type: Test
> Components: io-ideas
> Reporter: Dariusz Aniszewski
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
