[
https://issues.apache.org/jira/browse/BEAM-9603?focusedWorklogId=435342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-435342
]
ASF GitHub Bot logged work on BEAM-9603:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/20 04:41
Start Date: 20/May/20 04:41
Worklog Time Spent: 10m
Work Description: y1chi commented on a change in pull request #11756:
URL: https://github.com/apache/beam/pull/11756#discussion_r427737289
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -962,16 +971,25 @@ private Progress getProgress() {
.build());
}
- private <K> void processTimer(String timerId, TimeDomain timeDomain,
Timer<K> timer) {
+ private <K> void processTimer(
+ String timerIdOrTimerFamilyId, TimeDomain timeDomain, Timer<K> timer) {
currentTimer = timer;
currentTimeDomain = timeDomain;
onTimerContext = new OnTimerContext<>(timer.getUserKey());
+ String timerId =
+ timerIdOrTimerFamilyId.startsWith(TimerFamilyDeclaration.PREFIX)
Review comment:
it will be ignored anyway, apparently only one of timerId or the
timerFamilyId takes effect.
https://github.com/apache/beam/blob/591de3473144de54beef0932131025e2a4d8504b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/ByteBuddyDoFnInvokerFactory.java#L223
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 435342)
Time Spent: 3h (was: 2h 50m)
> Support Dynamic Timer in Java SDK over FnApi
> --------------------------------------------
>
> Key: BEAM-9603
> URL: https://issues.apache.org/jira/browse/BEAM-9603
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness
> Reporter: Boyuan Zhang
> Assignee: Yichi Zhang
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
