[
https://issues.apache.org/jira/browse/BEAM-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Burke updated BEAM-10051:
--------------------------------
Description:
This check
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/harness/datamgr.go#L269
in it's current position prevents the "normal teardown" that the reader
expects. This means that readers for instructions that terminate early such as
due to splitting stay resident in memory and never close.
In practice this is benign as the buffer would already be closed, but with
streaming this memory leak would become noticable.
The fix is to move the check to after the sentinel check, and additionally
check there for early termination to avoid closing the buffer twice.
> Misordered check WRT closed data readers.
> -----------------------------------------
>
> Key: BEAM-10051
> URL: https://issues.apache.org/jira/browse/BEAM-10051
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P2
>
> This check
> https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/harness/datamgr.go#L269
> in it's current position prevents the "normal teardown" that the reader
> expects. This means that readers for instructions that terminate early such
> as due to splitting stay resident in memory and never close.
> In practice this is benign as the buffer would already be closed, but with
> streaming this memory leak would become noticable.
> The fix is to move the check to after the sentinel check, and additionally
> check there for early termination to avoid closing the buffer twice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
