[
https://issues.apache.org/jira/browse/BEAM-8910?focusedWorklogId=437537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437537
]
ASF GitHub Bot logged work on BEAM-8910:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/20 04:04
Start Date: 27/May/20 04:04
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-634324376
@pabloem, would you mind squashing the commits that happened after the last
review iteration (but please don't squash earlier commits until review is
finalized) and resolving any comments that are already addressed? You can
also delete the "Run postcommit..." which would make it easier to follow
up on remaining comment threads.
On Thu, May 21, 2020 at 12:52 PM Pablo <[email protected]> wrote:
> *@pabloem* commented on this pull request.
> ------------------------------
>
> In sdks/python/apache_beam/io/gcp/bigquery.py
> <https://github.com/apache/beam/pull/11086#discussion_r428877884>:
>
> > @@ -610,7 +611,8 @@ def __init__(
> coder=None,
> use_standard_sql=False,
> flatten_results=True,
> - kms_key=None):
> + kms_key=None,
> + use_json_exports=False):
>
> Restarting this discussion after some rebasing and preparing...
>
> I think I'd prefer to allow users to choose the export file format. This
> is what we do for writing to BQ in Java and Python. Allowing users to
> choose output type for specific column types would add overhead of (if avro
> and json_format_bytes: formatbytes; if avro and json_datetime_format:
> formatdatetime; if not avro and not json_format_bytes: formatbytes; ...).
>
> We can discourage users from using JSON (AVRO is already the default) -
> and eventually stop supporting it if that makes sense. Thoughts?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/11086#discussion_r428877884>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ACHZCYCRXV5WRILNRQP2IZDRSWBA3ANCNFSM4LESJLFQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 437537)
Time Spent: 12h 40m (was: 12.5h)
> Use AVRO instead of JSON in BigQuery bounded source.
> ----------------------------------------------------
>
> Key: BEAM-8910
> URL: https://issues.apache.org/jira/browse/BEAM-8910
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Kamil Wasilewski
> Assignee: Pablo Estrada
> Priority: P3
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
> The proposed BigQuery bounded source in Python SDK (see PR:
> [https://github.com/apache/beam/pull/9772)] uses a BigQuery export job to
> take a snapshot of the table and read from each produced JSON file. A
> performance improvement can be gain by switching to AVRO instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
