[
https://issues.apache.org/jira/browse/BEAM-7770?focusedWorklogId=437830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437830
]
ASF GitHub Bot logged work on BEAM-7770:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/20 14:58
Start Date: 27/May/20 14:58
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#11357:
URL: https://github.com/apache/beam/pull/11357#discussion_r431203774
##########
File path:
sdks/java/io/solr/src/test/java/org/apache/beam/sdk/io/solr/SolrIOTest.java
##########
@@ -155,6 +155,23 @@ public void testRead() throws Exception {
pipeline.run();
}
+ @Test
+ public void testReadAll() throws Exception {
+ SolrIOTestUtils.insertTestDocuments(SOLR_COLLECTION, NUM_DOCS, solrClient);
+
+ PCollection<SolrDocument> output =
+ pipeline
+ .apply(
+ Create.of(
+ SolrIO.read()
+ .withConnectionConfiguration(connectionConfiguration)
+ .from(SOLR_COLLECTION)
+ .withBatchSize(101)))
+ .apply(SolrIO.readAll());
+ PAssert.thatSingleton(output.apply("Count",
Count.globally())).isEqualTo(NUM_DOCS);
Review comment:
I believe we can improve this test in the future by reading with
multiple `Read`s (the goal of adding `readAll()`) and check the content of read
messages (not only count).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 437830)
Time Spent: 1h 20m (was: 1h 10m)
> Add ReadAll transform for SolrIO
> --------------------------------
>
> Key: BEAM-7770
> URL: https://issues.apache.org/jira/browse/BEAM-7770
> Project: Beam
> Issue Type: Improvement
> Components: io-java-solr
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: P3
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> SolrIO already uses internally a composable approach but we need to expose an
> explicit ReadAll transform that allows user to create reads in the middle of
> the Pipeline to improve composability (e.g. Reads in the middle of a
> Pipeline).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
