[
https://issues.apache.org/jira/browse/BEAM-10054?focusedWorklogId=437938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437938
]
ASF GitHub Bot logged work on BEAM-10054:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/20 18:03
Start Date: 27/May/20 18:03
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on a change in pull request
#11777:
URL: https://github.com/apache/beam/pull/11777#discussion_r431341368
##########
File path: sdks/python/apache_beam/transforms/trigger.py
##########
@@ -1368,7 +1368,7 @@ def _output(
if timestamp is None:
# If no watermark hold was set, output at end of window.
timestamp = window.max_timestamp()
- elif input_watermark < window.end and self.trigger_fn.has_ontime_pane():
+ elif output_watermark < window.end and self.trigger_fn.has_ontime_pane():
Review comment:
Yeah this looks good, thanks for thanks for the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 437938)
Time Spent: 1.5h (was: 1h 20m)
> Direct Runner execution stalls with test pipeline
> -------------------------------------------------
>
> Key: BEAM-10054
> URL: https://issues.apache.org/jira/browse/BEAM-10054
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Internally, we have a test pipeline which runs with the DirectRunner. When
> upgrading from 2.18.0 to 2.21.0 the test failed with the following exception:
> {noformat}
> tp = Exception('Monitor task detected a pipeline stall.',), value = None, tb
> = None
> def raise_(tp, value=None, tb=None):
> """
> A function that matches the Python 2.x ``raise`` statement. This
> allows re-raising exceptions with the cls value and traceback on
> Python 2 and 3.
> """
> if value is not None and isinstance(tp, Exception):
> raise TypeError("instance exception may not have a separate
> value")
> if value is not None:
> exc = tp(value)
> else:
> exc = tp
> if exc.__traceback__ is not tb:
> raise exc.with_traceback(tb)
> > raise exc
> E Exception: Monitor task detected a pipeline stall.
> {noformat}
> I was able to bisect the error. This commit introduced the failure:
> https://github.com/apache/beam/commit/ea9b1f350b88c2996cafb4d24351869e82857731
> If the following conditions evaluates to False, the pipeline runs correctly:
> https://github.com/apache/beam/commit/ea9b1f350b88c2996cafb4d24351869e82857731#diff-2bb845e226f3a97c0f0f737d0558c5dbR1273
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
