[
https://issues.apache.org/jira/browse/BEAM-9894?focusedWorklogId=438683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-438683
]
ASF GitHub Bot logged work on BEAM-9894:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/20 11:31
Start Date: 29/May/20 11:31
Worklog Time Spent: 10m
Work Description: purbanow commented on a change in pull request #11794:
URL: https://github.com/apache/beam/pull/11794#discussion_r432423695
##########
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##########
@@ -257,23 +301,12 @@
}
/**
- * Name of the cloud bucket (GCS by now) to use as tmp location of CSVs
during COPY statement.
- *
- * @param stagingBucketName - String with the name of the bucket.
- */
- public Read<T> withStagingBucketName(String stagingBucketName) {
- return toBuilder().setStagingBucketName(stagingBucketName).build();
- }
-
- /**
- * Name of the Storage Integration in Snowflake to be used. See
- *
https://docs.snowflake.com/en/sql-reference/sql/create-storage-integration.html
for
- * reference.
+ * A location object which contains connection config between Snowflake
and GCP.
*
- * @param integrationName - String with the name of the Storage
Integration.
+ * @param location - an instance of {@link Location}.
*/
- public Read<T> withIntegrationName(String integrationName) {
- return toBuilder().setIntegrationName(integrationName).build();
+ public Read<T> via(Location location) {
Review comment:
No reason. I changed to `withLocation ` to be more consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 438683)
Time Spent: 2.5h (was: 2h 20m)
> Add batch SnowflakeIO.Write to Java SDK
> ---------------------------------------
>
> Key: BEAM-9894
> URL: https://issues.apache.org/jira/browse/BEAM-9894
> Project: Beam
> Issue Type: New Feature
> Components: io-ideas
> Reporter: Dariusz Aniszewski
> Assignee: Pawel Urbanowicz
> Priority: P2
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
