[
https://issues.apache.org/jira/browse/BEAM-10063?focusedWorklogId=440415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440415
]
ASF GitHub Bot logged work on BEAM-10063:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/20 20:02
Start Date: 02/Jun/20 20:02
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #11785:
URL: https://github.com/apache/beam/pull/11785#discussion_r434143456
##########
File path: sdks/python/apache_beam/dataframe/doctests.py
##########
@@ -242,6 +242,11 @@ def __init__(self, env, use_beam=True, **kwargs):
**kwargs)
def run(self, test, **kwargs):
+ for example in test.examples:
+ if example.exc_msg is None:
+ # Don't fail doctests that raise this error.
+ example.exc_msg = (
+ 'apache_beam.dataframe.frame_base.WontImplementError: ...')
Review comment:
Correct, but I only know that from reading the code. (The implementation
doesn't have any ability to customize this, e.g. the OutputChecker doesn't get
invoked on exceptional case.) I decided depending on this was preferable to
copying and modifying the implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 440415)
Time Spent: 50m (was: 40m)
> Run pandas doctests for Beam dataframes API.
> --------------------------------------------
>
> Key: BEAM-10063
> URL: https://issues.apache.org/jira/browse/BEAM-10063
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
