[
https://issues.apache.org/jira/browse/BEAM-10066?focusedWorklogId=441698&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441698
]
ASF GitHub Bot logged work on BEAM-10066:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/20 06:22
Start Date: 05/Jun/20 06:22
Worklog Time Spent: 10m
Work Description: naipath commented on pull request #11799:
URL: https://github.com/apache/beam/pull/11799#issuecomment-639283676
@iemejia Thanks for the tips and taking the time to help me out!
I ran spotlessApply, for some reason I forgot to do it 😊.
The commit title now includes the ticket `[BEAM-10066]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 441698)
Remaining Estimate: 20m (was: 0.5h)
Time Spent: 40m (was: 0.5h)
> Support ValueProvider for RedisIO
> ---------------------------------
>
> Key: BEAM-10066
> URL: https://issues.apache.org/jira/browse/BEAM-10066
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Affects Versions: 2.20.0
> Reporter: Teije van Sloten
> Assignee: Teije van Sloten
> Priority: P3
> Original Estimate: 1h
> Time Spent: 40m
> Remaining Estimate: 20m
>
> RedisIO doesn't have support for `ValueProvider` when setting up the
> connection with Redis, therefore I cannot provide the connection at runtime
> of the application only at compile time.
> This will involve wrapping the RedisConnectionConfiguration with
> ValueProvider and ensuring that the building the configuration still supports
> values without ValueProvider.
> E.g.:
> Â
> {code:java}
> public abstract class RedisConnectionConfiguration implements Serializable {
> abstract ValueProvider<String> host();
> abstract ValueProvider<Integer> port();
> @Nullable
> abstract ValueProvider<String> auth();
> abstract ValueProvider<Integer> timeout();
> abstract ValueProvider<Boolean> ssl();
> abstract Builder builder();
> }
> Â
> {code}
> Â
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
