[
https://issues.apache.org/jira/browse/BEAM-9191?focusedWorklogId=442735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442735
]
ASF GitHub Bot logged work on BEAM-9191:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/20 15:52
Start Date: 09/Jun/20 15:52
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #11953:
URL: https://github.com/apache/beam/pull/11953#issuecomment-640886850
R: @robinyqiu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 442735)
Remaining Estimate: 0h
Time Spent: 10m
> CAST does not work in some cases due to bugs in Calcite unparsing
> -----------------------------------------------------------------
>
> Key: BEAM-9191
> URL: https://issues.apache.org/jira/browse/BEAM-9191
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Priority: P3
> Labels: beam-fixit
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For example:
> "CAST(xxx AS TIMESTAMP)" is unparsed to "CAST(xxx AS TIMESTAMP(0))"
> The fix is already in the newest version of BigQuerySqlDialect.java in
> Calcite (using
> [SqlAlienSystemTypeNameSpec|https://github.com/apache/calcite/blob/3621b61ea0bca953652a2e6d1838e5a296c6a007/core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java#L293]),
> so this issue will be fixed after we update our vendored Calcite version.
> I tried to patch the change to BeamBigQuerySqlDialect.java (similar to what
> we did for other features) but this change is very large (multiple new
> classes) to patch.
> cc: [~apilloud]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
