[
https://issues.apache.org/jira/browse/BEAM-8828?focusedWorklogId=443052&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443052
]
ASF GitHub Bot logged work on BEAM-8828:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/20 16:26
Start Date: 09/Jun/20 16:26
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#11951:
URL: https://github.com/apache/beam/pull/11951#discussion_r436984551
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryTableProviderTest.java
##########
@@ -91,6 +94,16 @@ public void testSelectExportMethod() {
assertEquals(Method.EXPORT, sqlTable.method);
}
+ @Test
+ public void testSelectWriteDispositionMethod() {
+ Table table =
+ fakeTableWithProperties(
+ "hello", "{ " + WRITE_DISPOSITION_PROPERTY + ": " + "\"" +
WriteDisposition.WRITE_APPEND.toString() + "\" }");
+ BigQueryTable sqlTable = (BigQueryTable) provider.buildBeamSqlTable(table);
+
+ assertEquals(WriteDisposition.WRITE_APPEND, sqlTable.writeDisposition);
+ }
+
Review comment:
Could you add a test like this for EMPTY and TRUNCATE as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 443052)
Time Spent: 20m (was: 10m)
> BigQueryTableProvider should allow configuration of write disposition
> ---------------------------------------------------------------------
>
> Key: BEAM-8828
> URL: https://issues.apache.org/jira/browse/BEAM-8828
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Brian Hulette
> Assignee: Scott Lukas
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It should be possible to set BigQueryIO's
> [writeDisposition|https://github.com/apache/beam/blob/b446304f75078ca9c97437e685409c31ceab7503/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java#L2122-L2125]
> in a Beam SQL big query table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
