[
https://issues.apache.org/jira/browse/BEAM-10033?focusedWorklogId=443458&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443458
]
ASF GitHub Bot logged work on BEAM-10033:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/20 23:09
Start Date: 09/Jun/20 23:09
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #11957:
URL: https://github.com/apache/beam/pull/11957#issuecomment-641627057
Well. Some tests are failing and I realized this turns out to be not that
simple change. There are subtle differences between Beam schema and ZetaSQL
struct that prevents this change (e.g. if ZetaSQL types are by default nullable
whereas it is a label in Beam field type; and ZetaSQL struct allows fields with
same name but Beam does not).
I will take more time to figure out what is the correct thing to do here. In
the meanwhile, I will send out some other small cleanup PRs for review. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 443458)
Time Spent: 20m (was: 10m)
> zetaSqlValueToJavaObject shouldn't take Field Type
> --------------------------------------------------
>
> Key: BEAM-10033
> URL: https://issues.apache.org/jira/browse/BEAM-10033
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Assignee: Robin Qiu
> Priority: P2
> Labels: beam-fixit
> Time Spent: 20m
> Remaining Estimate: 0h
>
> ZetaSQL Values contain a type, we don't use that type information when
> converting, instead we use the output schema.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
