[
https://issues.apache.org/jira/browse/BEAM-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132509#comment-17132509
]
Beam JIRA Bot commented on BEAM-671:
------------------------------------
This issue is assigned but has not received an update in 30 days so it has been
labeled "stale-assigned". If you are still working on the issue, please give an
update and remove the label. If you are no longer working on the issue, please
unassign so someone else may work on it. In 7 days the issue will be
automatically unassigned.
> Update Read PTransform to implicitly use maxNumRecords and maxReadTime
> ----------------------------------------------------------------------
>
> Key: BEAM-671
> URL: https://issues.apache.org/jira/browse/BEAM-671
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: P2
> Labels: stale-assigned
>
> Today, almost all IOs {{Read}} {{PTransform}}, when using an
> {{UnboundedSource}}, do the following in the {{apply()}}:
> {code:java}
> org.apache.beam.sdk.io.Read.Unbounded<byte[]> unbounded =
> org.apache.beam.sdk.io.Read.from(getSource());
> PTransform<PBegin, PCollection<byte[]>> transform = unbounded;
> if (maxNumRecords() < Long.MAX_VALUE || maxReadTime() != null) {
> transform =
> unbounded.withMaxReadTime(maxReadTime()).withMaxNumRecords(maxNumRecords());
> }
> return input.getPipeline().apply(transform);
> {code}
> To avoid to duplicate this code bunch of time, it would make sense to do it
> by default in {{org.apache.beam.sdk.io.Read}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
