[ 
https://issues.apache.org/jira/browse/BEAM-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132475#comment-17132475
 ] 

Beam JIRA Bot commented on BEAM-1306:
-------------------------------------

This issue is assigned but has not received an update in 30 days so it has been 
labeled "stale-assigned". If you are still working on the issue, please give an 
update and remove the label. If you are no longer working on the issue, please 
unassign so someone else may work on it. In 7 days the issue will be 
automatically unassigned.

> Support additional configuration in BigQueryServices.insertAll()
> ----------------------------------------------------------------
>
>                 Key: BEAM-1306
>                 URL: https://issues.apache.org/jira/browse/BEAM-1306
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>            Reporter: Pei He
>            Assignee: Pei He
>            Priority: P2
>              Labels: stale-assigned
>
> ignoreUnknownValues is requested in 
> https://issues.apache.org/jira/browse/BEAM-1267
> There are additional configurations that could be useful.
> TableDataInsertAllRequest content = new TableDataInsertAllRequest();
> content.setSkipInvalidRows();
> content.setTemplateSuffix();
> content.setKind();
>             
> I think we can improve the BigQueryServices interface by define it as:
> void insertAll(TableReference ref, Collection<TableDataInsertAllRequest> 
> request);
> and, provided a static method to prepare requests:
> List<TableDataInsertAllRequest> makeInsertBatches(List<TableRow> rowList, 
> @Nullable List<String> insertIdList);
> Then, client can set additional config in the returned list.
> Reference:
> GcsUtil.java has similar implementation in makeCopyBatches() and 
> executeBatches().
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java#L550



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to