[
https://issues.apache.org/jira/browse/BEAM-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132239#comment-17132239
]
Beam JIRA Bot commented on BEAM-4114:
-------------------------------------
This issue is assigned but has not received an update in 30 days so it has been
labeled "stale-assigned". If you are still working on the issue, please give an
update and remove the label. If you are no longer working on the issue, please
unassign so someone else may work on it. In 7 days the issue will be
automatically unassigned.
> Allow null as leftNullValue/rightNullValue in Join.fullOuterJoin()
> ------------------------------------------------------------------
>
> Key: BEAM-4114
> URL: https://issues.apache.org/jira/browse/BEAM-4114
> Project: Beam
> Issue Type: Improvement
> Components: extensions-java-join-library
> Affects Versions: 2.4.0
> Reporter: Robin Trietsch
> Assignee: Robin Trietsch
> Priority: P2
> Labels: stale-assigned
>
> When using the
> [Join.fullOuterJoin()|https://beam.apache.org/documentation/sdks/javadoc/2.4.0/org/apache/beam/sdk/extensions/joinlibrary/Join.html#fullOuterJoin-org.apache.beam.sdk.values.PCollection-org.apache.beam.sdk.values.PCollection-V1-V2-],
> a checkNotNull() is done for the
> [leftNullValue|https://github.com/apache/beam/blob/master/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java#L207]
> and
> [rightNullValue|https://github.com/apache/beam/blob/master/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java#L208].
> However, it makes more sense to allow null values, since sometimes, if the
> key used for the join is not the same, you'd like to see that the value will
> become null. This should be decided by the developer, and not by the join
> library.
> Looking at the source code, this is also supported by
> [KV.of()|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/KV.java#L42]
> (it allows null values), which is used in Join.fullOuterJoin().
> If required, I can create a pull request on GitHub.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
