[
https://issues.apache.org/jira/browse/BEAM-10217?focusedWorklogId=443910&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443910
]
ASF GitHub Bot logged work on BEAM-10217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/20 18:12
Start Date: 10/Jun/20 18:12
Worklog Time Spent: 10m
Work Description: udim commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-642175471
> Seeing a failure in
PortableRunnerTestWithExternalEnv.test_error_traceback_includes_user_code, not
sure if related.
https://issues.apache.org/jira/browse/BEAM-8878
> The change LGTM and verified that it addresses
[[BEAM-10217](https://issues.apache.org/jira/browse/BEAM-10217)]. Would it make
sense to add this test:
[91d6469#diff-f14ce51d033ed4ff23353402681571ecR195](https://github.com/apache/beam/commit/91d6469e05b61df0bb19f2442b159129ea8ddeef#diff-f14ce51d033ed4ff23353402681571ecR195)
?
Thanks for that test. I did use it to figure out the core issue. However I
think the test in this PR more precisely tests the issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 443910)
Time Spent: 1h (was: 50m)
> Suboptimal type inference on Python 3.6
> ---------------------------------------
>
> Key: BEAM-10217
> URL: https://issues.apache.org/jira/browse/BEAM-10217
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Udi Meiri
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Following trivial_inference_test fails for me with AssertionError: ::
> List[Tuple[Person, int]] != List[Any] on Python 3.6.8; Passed on 3.5.2, 3.5.6
> and 3.7.3.
> {noformat}
> def testMethodReturnsTuple(self):
> class Person(object):
> def __init__(self, name):
> self.name = name
> def parse_record(name_and_age):
> name, age = name_and_age.split(',')
> return Person(name), int(age)
> self.assertReturnType(typehints.List[typehints.Tuple[Person, int]],
> lambda record: [parse_record(record)], [str])
> {noformat}
> See: https://github.com/apache/beam/pull/11954.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
