[
https://issues.apache.org/jira/browse/BEAM-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kenneth Knowles updated BEAM-1062:
----------------------------------
Comment: was deleted
(was: GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1462
[BEAM-1062] Shade the SDK more fully; everything but a whitelist
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This is a re-opening of a past change. Previously, issues with snappy's use
of reflection blocked progress. Things have changed a lot since then so let's
put a little more effort into this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam shade-SDK
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1462.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1462
----
commit 78dd9e3583349d232c2514a0380fa59b0bbd2791
Author: Kenneth Knowles <[email protected]>
Date: 2016-07-15T20:47:41Z
Upgrade snappy version and move to dependencyManagement
commit 05214785fa254ee434e8fdb0ae728c8505cb1cdd
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-30T04:06:54Z
Shade more in the SDK; everything except a whitelist
----
)
> Shade SDK based on a list of things to not shade instead of a list of things
> to shade
> -------------------------------------------------------------------------------------
>
> Key: BEAM-1062
> URL: https://issues.apache.org/jira/browse/BEAM-1062
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: P2
> Labels: stale-P2
> Fix For: Not applicable
>
>
> This is a more robust way to manage the surface of dependencies we introduce.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
