[
https://issues.apache.org/jira/browse/BEAM-8596?focusedWorklogId=444260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444260
]
ASF GitHub Bot logged work on BEAM-8596:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/20 13:19
Start Date: 11/Jun/20 13:19
Worklog Time Spent: 10m
Work Description: sabhyankar commented on a change in pull request #11950:
URL: https://github.com/apache/beam/pull/11950#discussion_r438774319
##########
File path:
sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkIO.java
##########
@@ -77,32 +78,48 @@
*
* PCollection<SplunkWriteError> errors =
* events.apply("WriteToSplunk",
- * SplunkIO.writeBuilder()
- * .withToken(token)
- * .withUrl(url)
- * .withBatchCount(batchCount)
- * .withParallelism(parallelism)
- * .withDisableCertificateValidation(true)
- * .build());
+ * SplunkIO.write(url, token)
+ * .withBatchCount(batchCount)
+ * .withParallelism(parallelism)
+ * .withDisableCertificateValidation(true));
* }</pre>
*/
@Experimental(Kind.SOURCE_SINK)
public class SplunkIO {
+ /**
+ * Write to Splunk's Http Event Collector (HEC).
+ *
+ * @param url splunk hec url
+ * @param token splunk hec authentication token
Review comment:
A token is required in order to use HEC and each end point has at-least
one token. So this would be a required param. (See: [Using http event
collector](https://docs.splunk.com/Documentation/Splunk/8.0.4/Data/UsetheHTTPEventCollector#Create_an_Event_Collector_token))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 444260)
Time Spent: 1h 40m (was: 1.5h)
> Add SplunkIO transform to write messages to Splunk
> --------------------------------------------------
>
> Key: BEAM-8596
> URL: https://issues.apache.org/jira/browse/BEAM-8596
> Project: Beam
> Issue Type: New Feature
> Components: io-ideas
> Reporter: Sameer Abhyankar
> Assignee: Sameer Abhyankar
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Add a SplunkIO transform to write messages to Splunk's HTTP Event Collector
> end point. We already have an implementation [1] that works well and we are
> looking to contribute this to Beam.
>
> [1]
> [https://github.com/GoogleCloudPlatform/DataflowTemplates/tree/master/src/main/java/com/google/cloud/teleport/splunk]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
