[
https://issues.apache.org/jira/browse/BEAM-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pedro Teixeira updated BEAM-10243:
----------------------------------
Description:
In the following code:
{code:java}
public FieldValueBuilder withFieldValues(Map<String, Object> values) {
checkState(values.isEmpty());
return new FieldValueBuilder(schema, null).withFieldValues(values);
}
{code}
checkState should check `this.values` instead of the passed arguments.
The issue is that as it is now, we cannot use this function to build a Row from
Map.
thanks.
was:
In the following code:
public FieldValueBuilder withFieldValues(Map<String, Object> values) {
checkState(values.isEmpty());
return new FieldValueBuilder(schema, null).withFieldValues(values);
}
checkState should check `this.values` instead of the passed arguments.
The issue is that as it is now, we cannot use this function to build a Row from
Map.
thanks.
> Incorrect checkState condition in withFieldValues in Row.java
> -------------------------------------------------------------
>
> Key: BEAM-10243
> URL: https://issues.apache.org/jira/browse/BEAM-10243
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.22.0
> Reporter: Pedro Teixeira
> Priority: P2
>
>
> In the following code:
> {code:java}
> public FieldValueBuilder withFieldValues(Map<String, Object> values) {
> checkState(values.isEmpty());
> return new FieldValueBuilder(schema, null).withFieldValues(values);
> }
> {code}
>
> checkState should check `this.values` instead of the passed arguments.
> The issue is that as it is now, we cannot use this function to build a Row
> from Map.
>
> thanks.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
