[
https://issues.apache.org/jira/browse/BEAM-7163?focusedWorklogId=445059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445059
]
ASF GitHub Bot logged work on BEAM-7163:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/20 17:37
Start Date: 12/Jun/20 17:37
Worklog Time Spent: 10m
Work Description: pskevin commented on a change in pull request #11999:
URL: https://github.com/apache/beam/pull/11999#discussion_r439556128
##########
File path: sdks/go/pkg/beam/testing/passert/sum.go
##########
@@ -22,9 +22,9 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
)
-// Sum validates that the incoming PCollection<int> is a singleton
-// with the given value. Specialized version of Equals that avoids
-// a lot of machinery for testing.
+// Sum validates that the sum and count of elements in the incoming
PCollection<int> is
+// the same as the given sum and count, under coder equality. Specialized
version of Equals
+// that avoids a lot of machinery for testing.
Review comment:
Noted and reflected changes accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 445059)
Time Spent: 1h 10m (was: 1h)
> Godoc for passert.Sum seems wrong
> ---------------------------------
>
> Key: BEAM-7163
> URL: https://issues.apache.org/jira/browse/BEAM-7163
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Damien Desfontaines
> Assignee: Kevin Sijo Puthusseri
> Priority: P2
> Labels: stale-P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> From
> [https://godoc.org/github.com/apache/beam/sdks/go/pkg/beam/testing/passert#Sum]:
> > Sum validates that the incoming PCollection<int> is a singleton with the
> > given value.
> Why is there a size argument if the input is supposed to be a singleton?
> From the implementation, it seems that Sum sums all elements from the input
> PCollection (which must be int, apparently?), and checks both the number of
> elements and their sum.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
