[
https://issues.apache.org/jira/browse/BEAM-10254?focusedWorklogId=445217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445217
]
ASF GitHub Bot logged work on BEAM-10254:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/20 23:16
Start Date: 12/Jun/20 23:16
Worklog Time Spent: 10m
Work Description: udim opened a new pull request #12007:
URL: https://github.com/apache/beam/pull/12007
Fixes `convert_to_beam_type` on `typing.Pattern` and `typing.Match` (both of
type `typing._TypeAlias`) to not throw an exception.
Only Python versions 3.6.{8,9} are known to be affected.
Also merges 2 unit tests that should not have been split.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Samza | Spark
--- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 445217)
Remaining Estimate: 0h
Time Spent: 10m
> Python type hints: support typing.Pattern
> -----------------------------------------
>
> Key: BEAM-10254
> URL: https://issues.apache.org/jira/browse/BEAM-10254
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Failing test:
> {code}
> def test_pattern(self):
> self.assertEqual(
> typehints.Any, convert_to_beam_type(typing.Pattern))
> {code}
> {code}
> native_type_compatibility_test.py:113:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> native_type_compatibility.py:261: in convert_to_beam_type
> matched_entry = next((entry for entry in type_map if entry.match(typ)),
> None)
> native_type_compatibility.py:261: in <genexpr>
> matched_entry = next((entry for entry in type_map if entry.match(typ)),
> None)
> native_type_compatibility.py:98: in <lambda>
> return lambda user_type: _safe_issubclass(user_type, match_against)
> native_type_compatibility.py:87: in _safe_issubclass
> return issubclass(derived, parent)
> ../../../../../../.pyenv/versions/3.6.9/lib/python3.6/typing.py:1154: in
> __subclasscheck__
> return super().__subclasscheck__(cls)
> ../../../../../../.pyenv/versions/3.6.9/lib/python3.6/abc.py:209: in
> __subclasscheck__
> ok = cls.__subclasshook__(subclass)
> ../../../../../../.pyenv/versions/3.6.9/lib/python3.6/typing.py:876: in
> __extrahook__
> res = cls.__extra__.__subclasshook__(subclass)
> ../../../../../../.pyenv/versions/3.6.9/lib/python3.6/_collections_abc.py:353:
> in __subclasshook__
> 'send', 'throw', 'close')
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> C = Pattern[~AnyStr]
> methods = ('__iter__', '__next__', 'send', 'throw', 'close')
> def _check_methods(C, *methods):
> > mro = C.__mro__
> E AttributeError: '_TypeAlias' object has no attribute '__mro__'
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
