[
https://issues.apache.org/jira/browse/BEAM-10033?focusedWorklogId=446290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446290
]
ASF GitHub Bot logged work on BEAM-10033:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jun/20 05:15
Start Date: 16/Jun/20 05:15
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #11957:
URL: https://github.com/apache/beam/pull/11957#discussion_r440590858
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlUtils.java
##########
@@ -196,7 +196,55 @@ private static Value
beamLogicalObjectToZetaSqlValue(Object object, String ident
}
}
- // Value conversion: ZetaSQL => Beam
+ // Type conversion: ZetaSQL => Beam
+ public static FieldType zetaSqlTypeToBeamFieldType(Type type) {
Review comment:
Out of curiosity: so the ZetaSQL type does not carry nullability?
(otherwise seems the nullability of the type has lost in this conversion).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 446290)
Time Spent: 1h 20m (was: 1h 10m)
> zetaSqlValueToJavaObject shouldn't take Field Type
> --------------------------------------------------
>
> Key: BEAM-10033
> URL: https://issues.apache.org/jira/browse/BEAM-10033
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Assignee: Robin Qiu
> Priority: P2
> Labels: beam-fixit
> Fix For: 2.23.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> ZetaSQL Values contain a type, we don't use that type information when
> converting, instead we use the output schema.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
