[
https://issues.apache.org/jira/browse/BEAM-10197?focusedWorklogId=446882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446882
]
ASF GitHub Bot logged work on BEAM-10197:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jun/20 20:25
Start Date: 16/Jun/20 20:25
Worklog Time Spent: 10m
Work Description: saavan-google-intern commented on a change in pull
request #11939:
URL: https://github.com/apache/beam/pull/11939#discussion_r441120323
##########
File path: sdks/python/apache_beam/typehints/typehints.py
##########
@@ -435,10 +435,14 @@ def type_check(self, instance):
class TypeVariable(AnyTypeConstraint):
- def __init__(self, name):
+ def __init__(self, name, ignore_name=False):
self.name = name
+ self.ignore_name = ignore_name
def __eq__(self, other):
+ if self.ignore_name:
Review comment:
Thanks, pushed a fix - it's used for one test in
native_type_compatability_test.py
Also added unit tests for the new changes to TypeVariable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 446882)
Time Spent: 4.5h (was: 4h 20m)
> Support type hints for frozenset
> ---------------------------------
>
> Key: BEAM-10197
> URL: https://issues.apache.org/jira/browse/BEAM-10197
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Saavan Nanavati
> Priority: P2
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Beam's internal typing system currently supports type hints for set but not
> frozenset.
>
> This Jira ticket will add type annotation support for both frozenset and
> typing.FrozenSet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
