[
https://issues.apache.org/jira/browse/BEAM-10258?focusedWorklogId=447540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-447540
]
ASF GitHub Bot logged work on BEAM-10258:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/20 21:47
Start Date: 17/Jun/20 21:47
Worklog Time Spent: 10m
Work Description: saavan-google-intern commented on a change in pull
request #12009:
URL: https://github.com/apache/beam/pull/12009#discussion_r441852783
##########
File path: sdks/python/apache_beam/pvalue.py
##########
@@ -425,8 +441,7 @@ def _from_runtime_iterable(it, options):
def _view_options(self):
return {
- 'data': self._data,
- # For non-fn-api runners.
+ 'data': self._data, # For non-fn-api runners.
Review comment:
Yeah, yapf did that. I'm not sure why. When I run "yapf -ir ." from the
root python directory, a lot of files are re-formatted. Is this unexpected
behavior? If it's not, I can create an MR with just yapf changes to the entire
apache_beam module. Thoughts?
##########
File path: sdks/python/apache_beam/pvalue.py
##########
@@ -425,8 +441,7 @@ def _from_runtime_iterable(it, options):
def _view_options(self):
return {
- 'data': self._data,
- # For non-fn-api runners.
+ 'data': self._data, # For non-fn-api runners.
Review comment:
Yeah, yapf did that. I'm not sure why. When I run "yapf -ir ." from the
root python directory, a lot of files are re-formatted. Is this unexpected
behavior? If it's not, I can create an PR with just yapf changes to the entire
apache_beam module. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 447540)
Time Spent: 1h 20m (was: 1h 10m)
> Support type hint annotations on PTransform's expand()
> ------------------------------------------------------
>
> Key: BEAM-10258
> URL: https://issues.apache.org/jira/browse/BEAM-10258
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Saavan Nanavati
> Assignee: Saavan Nanavati
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
