[
https://issues.apache.org/jira/browse/BEAM-10141?focusedWorklogId=448102&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448102
]
ASF GitHub Bot logged work on BEAM-10141:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/20 23:04
Start Date: 18/Jun/20 23:04
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #11862:
URL: https://github.com/apache/beam/pull/11862#discussion_r442546599
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##########
@@ -179,25 +189,51 @@ public static ListHL7v2Messages readAll(List<String>
hl7v2Stores) {
return new ListHL7v2Messages(StaticValueProvider.of(hl7v2Stores),
StaticValueProvider.of(null));
}
+ /** Read all HL7v2 Messages from multiple stores as sendTime {@link
TimestampedValue}s. */
+ public static ListTimestampedHL7v2Messages
readAllWithTimestamps(List<String> hl7v2Stores) {
Review comment:
I think you can keep the static methods that exist and transition them
to use the builder underneath so you don't have to break the interface. This is
done in other IOs for common scenarios.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 448102)
Time Spent: 1.5h (was: 1h 20m)
> HL7v2IO read methods should assign sendTime timestamps
> ------------------------------------------------------
>
> Key: BEAM-10141
> URL: https://issues.apache.org/jira/browse/BEAM-10141
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Jacob Ferriero
> Assignee: Jacob Ferriero
> Priority: P3
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Per Suggestion in this
> [conversation|https://github.com/apache/beam/pull/11596#discussion_r427633240]
> Add timestamped values and watermark estimate to
> HL7v2IO.ListMessages. The same argument can be made for making HL7v2IO.Read
> return timestamped values.
> This should be optional and default to false to not be interface breaking.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
